-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Remove EarthlikeAtmosphere resources #22463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kfc35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic lgtm
mate-h
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the cleanup!
# Objective #20838 introduced an `EarthlikeAtmosphere` resource, which has a pre-prepared scattering medium resource for earthlike atmospheres. This means that every deployed Bevy app (even apps that don't need an atmosphere, or don't need the default earthlike atmosphere) will initialize the earthlike scattering medium (which processes the asset and writes data to the gpu). This is not desirable. The UX benefits for atmosphere initializers are not worth the price being paid: ```rust // EarthlikeAtmosphere resource fn setup(mut commands: Commands, earth_atmosphere: Res<EarthlikeAtmosphere>) { commands.spawn(( Camera3d::default(), earth_atmosphere.get(), )); } // Manual initialization fn setup(mut commands: Commands, mut scattering_mediums: ResMut<Assets<ScatteringMedium>>,) { commands.spawn(( Camera3d::default(), Atmosphere::earthlike(scattering_mediums.add(ScatteringMedium::default())), )); } ``` The manual approach also puts the Atmosphere component symbol back at the forefront and helps instruct developers on how this all actually works. ## Solution Remove the EarthlikeAtmosphere resource and add a default ScatteringMedium impl to make init slightly easier. As this feature will be introduced in 0.18, to avoid breaking people down the road we should land this PR in 0.18 as well.
|
may you update the migration guide as well ? It currently tells everyone to use the non existant EarthlikeAtmosphere resource |
|
@Inspirateur open an issue on bevyengine/bevy-website |
Objective
#20838 introduced an
EarthlikeAtmosphereresource, which has a pre-prepared scattering medium resource for earthlike atmospheres.This means that every deployed Bevy app (even apps that don't need an atmosphere, or don't need the default earthlike atmosphere) will initialize the earthlike scattering medium (which processes the asset and writes data to the gpu).
This is not desirable. The UX benefits for atmosphere initializers are not worth the price being paid:
The manual approach also puts the Atmosphere component symbol back at the forefront and helps instruct developers on how this all actually works.
Solution
Remove the EarthlikeAtmosphere resource and add a default ScatteringMedium impl to make init slightly easier.
As this feature will be introduced in 0.18, to avoid breaking people down the road we should land this PR in 0.18 as well.